Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back some previously removed utility functions to transfer #8004

Closed
gjermundgaraba opened this issue Feb 25, 2025 · 0 comments · Fixed by #8005
Closed

Add back some previously removed utility functions to transfer #8004

gjermundgaraba opened this issue Feb 25, 2025 · 0 comments · Fixed by #8005
Assignees

Comments

@gjermundgaraba
Copy link
Contributor

To lessen the upgrade burden from v8 -> v10, we should add back some of the utility functions that many have relied upon in the past as deprecated (and remove them in another upcoming release) from transfer.

Some will have a slightly modified function signature, but keep the name and return something similar enough that it can be used without too much change.

The initial list of functions to add back:

  • func (k Keeper) DenomPathFromHash(ctx sdk.Context, ibcDenom string) (string, error)
  • func SenderChainIsSource(sourcePort, sourceChannel, denom string) bool
  • func ReceiverChainIsSource(sourcePort, sourceChannel, denom string) bool
  • func GetDenomPrefix(portID, channelID string) string
  • func GetPrefixedDenom(portID, channelID, baseDenom string) string
  • func GetTransferCoin(portID, channelID, baseDenom string, amount sdkmath.Int) sdk.Coin
  • func ParseDenomTrace(rawDenom string) DenomTrace (will have to return Denom)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant