Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove docker builds from makefile #8

Closed
colin-axner opened this issue Mar 3, 2021 · 3 comments · Fixed by #2549
Closed

Remove docker builds from makefile #8

colin-axner opened this issue Mar 3, 2021 · 3 comments · Fixed by #2549

Comments

@colin-axner
Copy link
Contributor

The makefile needs to be update so the building of simd command work

@hiromaily
Copy link

hiromaily commented Jul 26, 2021

I have a same issue when building by make build-simd-all commands.

$ make build-simd-all                                                                                                                                                                          (git)-[main]
/usr/local/bin/docker rm latest-build || true
Error: No such container: latest-build
/usr/local/bin/docker run --volume=/Users/hiroki.yasui/go/src/github.com/cosmos/ibc-go:/sources:ro \
        --env TARGET_PLATFORMS='linux/amd64 darwin/amd64 linux/arm64 windows/amd64' \
        --env APP=simd \
        --env VERSION=0afa15a \
        --env COMMIT=0afa15af41997cfb4c5dd5f98de8043961e26195 \
        --env LEDGER_ENABLED=true \
        --name latest-build cosmossdk/rbuilder:latest
Unable to find image 'cosmossdk/rbuilder:latest' locally
latest: Pulling from cosmossdk/rbuilder
57df1a1f1ad8: Pull complete
71e126169501: Pull complete
1af28a55c3f3: Pull complete
03f1c9932170: Pull complete
f4773b341423: Pull complete
fb320882041b: Pull complete
24b0ad6f9416: Pull complete
948c129097c1: Pull complete
e826624c5cbf: Pull complete
59e51b1435b2: Pull complete
08be3a7c19b3: Pull complete
b9267aceca28: Pull complete
Digest: sha256:0870f37eb666e4c4be9fd22892a32c70247b177008fff06f27b2fb708fe95c34
Status: Downloaded newer image for cosmossdk/rbuilder:latest
/bin/bash: /sources/.build.sh: No such file or directory
make: *** [build-simd-all] Error 127

It would be caused by incompatible docker image from source code.

This docker image is not maintained for a while.
https://hub.docker.com/r/cosmossdk/rbuilder/tags?page=1&ordering=last_updated

@colin-axner
Copy link
Contributor Author

Looks like we are missing the .build.sh file https://github.com/cosmos/cosmos-sdk/blob/master/.build.sh

Is building simd in docker useful to you? make build and make install work. I'm wondering if we should just remove all the docker stuff for now

@hiromaily
Copy link

@colin-axner
As you said, make build is enough. But broken make task would confuse newbies like me.

@colin-axner colin-axner changed the title Fix docker builds Remove docker builds from makefile Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants