Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check collision resitstance of escrow addresses when using client ids. #7326

Closed
4 tasks
DimitrisJim opened this issue Sep 24, 2024 · 2 comments
Closed
4 tasks
Labels
feat: ibc-eureka needs investigation Issues that need some research before deciding approach or feasibility

Comments

@DimitrisJim
Copy link
Contributor

Raised by @damiannolan in slack:

Also if a new transfer channel is created with eureka/v2 and the client id is being used rather than channel id, doesn't that mean we should be rechecking the collision resistance for escrow addresses in transfer? I think it was tested for max uint32 with channel-{N} and if using client id it could be 07-tendermint-{N} or any-other-client-id-{N} which opens the door quite a bit


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added the needs investigation Issues that need some research before deciding approach or feasibility label Sep 24, 2024
@AdityaSripal
Copy link
Member

Made irrelevant by #7336

@DimitrisJim
Copy link
Contributor Author

Irrelevant. Eureka channels use the channel-N pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ibc-eureka needs investigation Issues that need some research before deciding approach or feasibility
Projects
Status: Done
Development

No branches or pull requests

3 participants