Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger support regression for MsgTransfer with ics20-2 #6465

Closed
Tracked by #6469
damiannolan opened this issue Jun 4, 2024 · 2 comments · Fixed by #6498
Closed
Tracked by #6469

Ledger support regression for MsgTransfer with ics20-2 #6465

damiannolan opened this issue Jun 4, 2024 · 2 comments · Fixed by #6498
Assignees
@damiannolan @chatton
Labels
20-transfer type: test coverage Increase code and use case coverage by means of unit, integration, e2e or manual tests
Milestone
ICS20 v2 (multi d...

Comments

@damiannolan
Copy link
Contributor

We should also test ledger support since MsgTransfer is being modified. I will add to the checklist on the issue.

Protobuf annoations may be required to new fields on MsgTransfer.

https://docs.cosmos.network/main/build/building-modules/protobuf-annoations

Originally posted by @damiannolan in #5793 (comment)
@damiannolan damiannolan moved this to Todo 🏃 in ibc-go Jun 4, 2024
@damiannolan
Copy link
Contributor Author

Will create a README.md or document to outline the steps for this process

@damiannolan damiannolan mentioned this issue Jun 4, 2024
Closed
16 tasks
@damiannolan damiannolan moved this from Todo 🏃 to In progress 👷 in ibc-go Jun 5, 2024
@crodriguezvega crodriguezvega added the type: test coverage Increase code and use case coverage by means of unit, integration, e2e or manual tests label Jun 5, 2024
@damiannolan damiannolan mentioned this issue Jun 5, 2024
Merged
10 tasks
@damiannolan
Copy link
Contributor Author

https://github.com/damiannolan/simd-scripts/blob/main/README.md#ledger-signing

This repo contains scripts for local deployment and a readme outlining steps for:

  • Installing simapp
  • Installing hermes
  • Creating a connection and ibc transfer channel
  • Ledger device setup and signing

@github-project-automation github-project-automation bot moved this from In progress 👷 to Done 🥳 in ibc-go Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

@chatton chatton

Labels
20-transfer type: test coverage Increase code and use case coverage by means of unit, integration, e2e or manual tests
Projects
ibc-go
Archived in project
Milestone
ICS20 v2 (multi denom) beta
Development

Successfully merging a pull request may close this issue.

imp: omit tokens from ledger device display when empty cosmos/ibc-go
3 participants
@damiannolan @crodriguezvega @chatton