Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICA simtests require an application to have both the controller and host modules. #6375

Closed
3 tasks
Taztingo opened this issue May 23, 2024 · 0 comments · Fixed by #6377
Closed
3 tasks

ICA simtests require an application to have both the controller and host modules. #6375

Taztingo opened this issue May 23, 2024 · 0 comments · Fixed by #6377
Labels
type: bug Something isn't working as expected

Comments

@Taztingo
Copy link
Contributor

Taztingo commented May 23, 2024

Summary of Bug

The simtests for v8.x has forced chains to require both the controller and host keepers for ICA because their sim proposals no longer test for nil. There are chains that may not want both the Controller and Host. The Provenance team first noticed this when we were trying to run our sim tests after updating ibc-go to v8.2.1.

Expected Behaviour

A chain should be able to choose if they want the ICA Controller, ICA Host, or both modules.

Version

v8.2.x

Steps to Reproduce

Run simtests on a chain that uses ICA and the simtests will produce proposals for both the Controller and Host.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants