Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use expected errors in ibc_module_test.go for transfer module #6214

Closed
3 tasks
colin-axner opened this issue Apr 23, 2024 · 0 comments · Fixed by #6217
Closed
3 tasks

Use expected errors in ibc_module_test.go for transfer module #6214

colin-axner opened this issue Apr 23, 2024 · 0 comments · Fixed by #6217
Labels
20-transfer testing Testing package and unit/integration tests

Comments

@colin-axner
Copy link
Contributor

Summary

Transfer should be tested with expected errors rather than expected passing

Refactor expPass in the ibc_module_test.go to use expError

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
20-transfer testing Testing package and unit/integration tests
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: refactor used expected errors notional-labs/ibc-go
1 participant
@colin-axner