Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap error returned from ACK application callbacks #5694

Closed
3 tasks
chatton opened this issue Jan 23, 2024 · 0 comments · Fixed by #5695
Closed
3 tasks

Wrap error returned from ACK application callbacks #5694

chatton opened this issue Jan 23, 2024 · 0 comments · Fixed by #5695
Assignees
@chatton

Comments

@chatton
Copy link
Contributor

chatton commented Jan 23, 2024

Summary

In order to prevent application callbacks from potentially interfering with the upgrade process, we should explicitly wrap them in an upgrade error and set the upgrade sequence to be the current channel upgrade sequence.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wrap error returned from upgrade ACK application callbacks cosmos/ibc-go
1 participant
@chatton