Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow all wildcard for allowed clients #5316

Closed
3 tasks
colin-axner opened this issue Dec 5, 2023 · 0 comments · Fixed by #5429
Closed
3 tasks

Add allow all wildcard for allowed clients #5316

colin-axner opened this issue Dec 5, 2023 · 0 comments · Fixed by #5429
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

Add a wildcard to allow all client types. Traditionally we use "*". This would allow any wired up light client modules to be allowed by default. Governance could then override with a well formed list if it wants to exclude certain light client types.

Originally the AllowedClients list was to add a enable button for certain clients. Core IBC shipped with tendermint, solomachine and localhost but only tendermint was fully functional at launch which made it useful to allow the other types to be enabled over time. Later on we began to use this param to disable client types in security conscious situations. Given this later usage, it would have been more functional to add a DisallowedClients param, but so goes history


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner changed the title Add wildcard for allowed clients Add allow all wildcard for allowed clients Dec 5, 2023
@crodriguezvega crodriguezvega added this to the v8.1.0 milestone Jan 9, 2024
@charleenfei charleenfei moved this to In review in ibc-go Jan 12, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ibc-go Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants