Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback panics and out of gas errors are not emitted in events #4566

Closed
3 tasks
srdtrk opened this issue Sep 5, 2023 · 0 comments · Fixed by #4568
Closed
3 tasks

Callback panics and out of gas errors are not emitted in events #4566

srdtrk opened this issue Sep 5, 2023 · 0 comments · Fixed by #4568
Labels
callbacks middleware Issues for callbacks middleware type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@srdtrk
Copy link
Member

srdtrk commented Sep 5, 2023

Summary of Bug

The events should indicate that an error occurred during the callback if the callback cannot be executed due to a panic or an oog error. Currently, in these two cases, the event indicates that the callback was "successful".

Expected Behaviour

The callback event is emitted as a "failure" and a description of the error is given.

Version

modules/apps/callbacks/v0.1.0+ibc-go-v7.3

Steps to Reproduce

Both cases are clearly tested here. So this issue is already reproduced.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@srdtrk srdtrk added type: bug Something isn't working as expected callbacks middleware Issues for callbacks middleware labels Sep 5, 2023
@srdtrk srdtrk added type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. and removed type: bug Something isn't working as expected labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callbacks middleware Issues for callbacks middleware type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant