Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/Deprecate Coordinator in testing pkg #4002

Open
3 tasks
colin-axner opened this issue Jul 4, 2023 · 0 comments
Open
3 tasks

Remove/Deprecate Coordinator in testing pkg #4002

colin-axner opened this issue Jul 4, 2023 · 0 comments
Labels
needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.

Comments

@colin-axner
Copy link
Contributor

Summary

Remove or deprecate the Coordiantor in the testing pkg

Problem Definition

The Coordinator was originally created to have context on all of the chains. This was useful in managing a global time between the chains and allowing execution between chains.

Following proposed improvements in #3999, #1014, the coordinator type will likely not be very useful. At the moment it is a wrapper around the existing chains and the current global time. The test caller will already have access to all the chains, typically denoted via suite.chainA and suite.chainB and the global time can likely be accessed by all the chains without wrapping it in another type

Removing this extra layer of the testing pkg will simplify the concepts to understand when new developers approach the pkg.

Proposal

Following improvements in #1014 and #3999, we should consider deprecating or removing the Coordinator


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jul 4, 2023
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Issues that need discussion before they can be worked on testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
Status: Backlog 🕐
Development

No branches or pull requests

1 participant