Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics29: not possible to use relayer address as payee after setting a payee address #3162

Closed
2 of 3 tasks
crodriguezvega opened this issue Feb 17, 2023 · 2 comments · Fixed by #5441
Closed
2 of 3 tasks
Assignees
Labels
29-fee help wanted Issues for which we would appreciate help/support from the community type: bug Something isn't working as expected
Milestone

Comments

@crodriguezvega
Copy link
Contributor

crodriguezvega commented Feb 17, 2023

Thanks to @ljoss17 for reporting this issue!

Summary of Bug

Once MsgRegisterPayee is used to register a payee for a relayer it is not possible to revert back to using the relayer address as payee. Validation of the message currently makes it impossible to either set the payee address to the same as the relayer address, or set the payee to an empty string.

Expected Behaviour

Be able to use the relayer address as payee if I don't want to use a payee address set before.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega added the type: bug Something isn't working as expected label Feb 20, 2023
@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Feb 20, 2023
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Mar 27, 2023
@crodriguezvega crodriguezvega added this to the v8.0.0 milestone Mar 30, 2023
@crodriguezvega crodriguezvega added the help wanted Issues for which we would appreciate help/support from the community label May 15, 2023
@crodriguezvega crodriguezvega modified the milestones: v8.0.0, vNext Aug 17, 2023
@crodriguezvega crodriguezvega modified the milestones: v9.0.0, v8.1.0 Dec 7, 2023
@chandiniv1
Copy link
Contributor

@crodriguezvega do I need to change validations or anything else

@crodriguezvega
Copy link
Contributor Author

Thank you, @chandiniv1. I think removing the check msg.Relayer == msg.Payee (and any related tests) should be enough, so that a relayer can use its own address as payee if they wish to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
29-fee help wanted Issues for which we would appreciate help/support from the community type: bug Something isn't working as expected
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants