Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return nil if len(clients) == 0 in handleTendermintMigration #2947

Closed
crodriguezvega opened this issue Dec 16, 2022 · 0 comments · Fixed by #2948
Closed

return nil if len(clients) == 0 in handleTendermintMigration #2947

crodriguezvega opened this issue Dec 16, 2022 · 0 comments · Fixed by #2948
Assignees
@damiannolan
Labels
02-client
Milestone
02-client refacto...

Comments

@crodriguezvega
Copy link
Contributor

Add the following check

if len(clients) == 0 { 
  return nil 
}

here in handleTendermintMigration.
@crodriguezvega crodriguezvega added this to the 02-client refactor RC milestone Dec 16, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Dec 16, 2022
@damiannolan damiannolan self-assigned this Dec 16, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Dec 16, 2022
@damiannolan damiannolan mentioned this issue Dec 16, 2022
Merged
9 tasks
Repository owner moved this from In progress to Todo in ibc-go Dec 19, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor RC
Development

Successfully merging a pull request may close this issue.

chore: adding defensive check to v7 migrations cosmos/ibc-go
2 participants
@damiannolan @crodriguezvega