Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure e2e tests build correctly #2648

Closed
3 tasks
chatton opened this issue Nov 2, 2022 · 0 comments · Fixed by #2649
Closed
3 tasks

Ensure e2e tests build correctly #2648

chatton opened this issue Nov 2, 2022 · 0 comments · Fixed by #2649
Assignees

Comments

@chatton
Copy link
Contributor

chatton commented Nov 2, 2022

Summary of Bug

Currently the e2e build command we use does not work as expected ever since we restructured the tests to use separate packages.

See this conversation for more details.

We need to ensure that this fails if the e2e tests do not build correctly.

Expected Behaviour

PRs are blocked from merging if the e2e test code does not build.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@chatton chatton self-assigned this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant