Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICAD tests fail when specifying > 1 validator #2104

Closed
3 tasks
chatton opened this issue Aug 24, 2022 · 4 comments · Fixed by #2162
Closed
3 tasks

ICAD tests fail when specifying > 1 validator #2104

chatton opened this issue Aug 24, 2022 · 4 comments · Fixed by #2162
Assignees
Labels
Milestone

Comments

@chatton
Copy link
Contributor

chatton commented Aug 24, 2022

Summary of Bug

Since bumping the number of validators to 4 the icad tests seem to be timing out when broadcasting a MsgSubmitTx message.

We didn't catch this as these tests aren't run on every PR.

here is a sample failure

On a separate branch, I reset the version to 1 and ran this workflow and it passed.

We need to figure out if this is a genuine failure or if it is an issue with the test or test framework.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner
Copy link
Contributor

Can we retry these tests with increased validator set using the latest version of the go relayer? I saw an ica bug fix fixed there

@colin-axner
Copy link
Contributor

Unsure if it is related cosmos/relayer#953

@colin-axner
Copy link
Contributor

I can look into this

@colin-axner colin-axner self-assigned this Aug 29, 2022
@colin-axner colin-axner moved this to In progress in ibc-go Aug 29, 2022
@colin-axner colin-axner added this to the v5.0.0 milestone Aug 29, 2022
@colin-axner
Copy link
Contributor

Looks like none of the new icad tags include the time.Now() fix

Repository owner moved this from In progress to Done in ibc-go Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants