Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of Verify functions in 03-connection #1293

Closed
2 of 13 tasks
Tracked by #1294
, #1295 ,  #1296
...
colin-axner opened this issue Apr 25, 2022 · 0 comments
Closed
2 of 13 tasks
Tracked by #1294
, #1295 ,  #1296
...

Replace usage of Verify functions in 03-connection #1293

colin-axner opened this issue Apr 25, 2022 · 0 comments
Assignees
@damiannolan
Labels
03-connection
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Apr 25, 2022 •
edited
Loading

Summary

Sub-issue of #1145

Pre-requirements:

Replace usage of:

  • VerifyClientState
  • VerifyConsensusState
  • VerifyConnection
  • VerifyChannel
  • VerifyPacketCommitment
  • VerifyAcknowledgement
  • VerifyPacketReceipt
  • VerifyPacketReceiptAbsence

with the generic VerifyMembership and VerifyNonMembership functions.

Mostly likely can be done in a single pr, assuming the diffs don't get too large due to some unforseen issue. If there's a change that requires discussion, please split up the pr

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner moved this to On hold in ibc-go Apr 25, 2022
This was referenced Apr 25, 2022
Closed
Closed
Closed
@damiannolan damiannolan self-assigned this Jul 4, 2022
@damiannolan damiannolan moved this from On hold to In progress in ibc-go Jul 4, 2022
This was referenced Jul 4, 2022
Closed
Merged
@damiannolan damiannolan moved this from In progress to In review in ibc-go Jul 4, 2022
Repository owner moved this from In review to Done in ibc-go Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
03-connection
Projects
ibc-go
Archived in project
Milestone
02-client refactor beta
Development

No branches or pull requests
3 participants
@damiannolan @crodriguezvega @colin-axner