From 1df216fd0d2bc16098f403775f696385242eff2a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?colin=20axn=C3=A9r?= <25233464+colin-axner@users.noreply.github.com> Date: Thu, 25 May 2023 22:23:55 +0200 Subject: [PATCH] Revert "Save gas on IsFeeEnabled (backport #2786) (#2814)" (#3660) * Revert "Save gas on IsFeeEnabled (backport #2786) (#2814)" This reverts commit dd2c03e089cd5bf0e65a26a948b5d2fa8fca45bb. * remove additional change in changelog entry * update CHANGELOG * Update CHANGELOG.md --------- Co-authored-by: Carlos Rodriguez --- CHANGELOG.md | 6 ++++++ modules/apps/29-fee/keeper/keeper.go | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d72867b9fa..d54cbfb3e18 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,12 @@ Ref: https://keepachangelog.com/en/1.0.0/ # Changelog +## [[Unreleased]] + +### Bug Fixes + +* [\#3660](https://github.com/cosmos/ibc-go/pull/3660) Revert state-machine breaking improvement from PR [#2786](https://github.com/cosmos/ibc-go/pull/2786). + ## [v4.1.2](https://github.com/cosmos/ibc-go/releases/tag/v4.1.2) - 2023-05-25 ### Dependencies diff --git a/modules/apps/29-fee/keeper/keeper.go b/modules/apps/29-fee/keeper/keeper.go index 585ea5cbe6b..c60942debea 100644 --- a/modules/apps/29-fee/keeper/keeper.go +++ b/modules/apps/29-fee/keeper/keeper.go @@ -121,7 +121,7 @@ func (k Keeper) DeleteFeeEnabled(ctx sdk.Context, portID, channelID string) { // fee enabled flag for the given port and channel identifiers func (k Keeper) IsFeeEnabled(ctx sdk.Context, portID, channelID string) bool { store := ctx.KVStore(k.storeKey) - return store.Has(types.KeyFeeEnabled(portID, channelID)) + return store.Get(types.KeyFeeEnabled(portID, channelID)) != nil } // GetAllFeeEnabledChannels returns a list of all ics29 enabled channels containing portID & channelID that are stored in state