Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-order snapshot #852

Closed
Tracked by #851
cool-develope opened this issue Nov 15, 2023 · 4 comments
Closed
Tracked by #851

Post-order snapshot #852

cool-develope opened this issue Nov 15, 2023 · 4 comments
Assignees

Comments

@cool-develope
Copy link
Collaborator

cool-develope commented Nov 15, 2023

IAVL v1 and v0 export is based on post-order, implement post-order export for compatibility with IAVL v0 and v1

@github-project-automation github-project-automation bot moved this to 👀 To Do in Cosmos-SDK Nov 15, 2023
@cool-develope cool-develope self-assigned this Nov 15, 2023
@cool-develope cool-develope moved this from 👀 To Do to ✍ In Progress in Cosmos-SDK Nov 15, 2023
@tac0turtle
Copy link
Member

should we only do restore for post order that way its less code to maintain over the long term?

@yihuang
Copy link
Collaborator

yihuang commented Nov 15, 2023

#703

This compact format rely on post-order BTW.

@tac0turtle
Copy link
Member

we should evaluate which is overall better (compact and performant). I dont think we should support both in iavlv2, only one will get used in reality. This can come later

@cool-develope cool-develope moved this from ✍ In Progress to 📚 In review in Cosmos-SDK Nov 27, 2023
@cool-develope cool-develope moved this from 📚 In review to 🥳 Done in Cosmos-SDK Nov 28, 2023
@cool-develope
Copy link
Collaborator Author

with #853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🥳 Done
Development

No branches or pull requests

3 participants