Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadVersionForOverwriting doesn't commit #639

Closed
RavenXce opened this issue Dec 1, 2022 · 2 comments
Closed

LoadVersionForOverwriting doesn't commit #639

RavenXce opened this issue Dec 1, 2022 · 2 comments

Comments

@RavenXce
Copy link

RavenXce commented Dec 1, 2022

LoadVersionForOverwriting doesn't actually commit if fast node disabled:

if !tree.skipFastStorageUpgrade {

This also means cosmos-sdk rollback still doesn't work in all cases: cosmos/cosmos-sdk#11361

@yihuang
Copy link
Collaborator

yihuang commented Feb 8, 2023

I think it's fixed in current version

@RavenXce
Copy link
Author

Looks fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants