Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gov doc is not correct on proposal immediately be accepted #7625

Closed
4 tasks
yihuang opened this issue Oct 22, 2020 · 3 comments · Fixed by #14656
Closed
4 tasks

Gov doc is not correct on proposal immediately be accepted #7625

yihuang opened this issue Oct 22, 2020 · 3 comments · Fixed by #14656
Assignees
Labels
T:Docs Changes and features related to documentation.

Comments

@yihuang
Copy link
Collaborator

yihuang commented Oct 22, 2020

Summary of Bug

In doc of gov module, it says:

Namely, if the ratio of Yes votes to InitTotalVotingPowerexceeds 2:3, the proposal will be immediately accepted, even if the Voting period is not finished.

But according to our test, one still need to wait for voting_end_time even if all voted yes.

Version

v0.34.4-0.20201014201753-24714f80cb16

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@tomtau
Copy link
Contributor

tomtau commented Oct 22, 2020

a bigger related issue: #4628 (comment)

@yihuang
Copy link
Collaborator Author

yihuang commented Oct 26, 2020

Also this line: "Users that deposited on proposals can recover their
deposits if ... OR if the proposal never entered voting period"
is not correct according to our testing. in the test, the deposits are burned if the proposal never entered voting period.

@yihuang
Copy link
Collaborator Author

yihuang commented Oct 26, 2020

Also this line: "some participants can be forbidden to vote on a proposal under a
certain validator if participant bonded or unbonded Atoms to said validator after proposal
entered voting period"
, in our testing, the user delegates after proposal entered voting period, it still can vote with the newly bonded coins.

@clevinson clevinson added the T:Docs Changes and features related to documentation. label Nov 23, 2020
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Jan 16, 2023
@julienrbrt julienrbrt self-assigned this Jan 17, 2023
@julienrbrt julienrbrt moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jan 17, 2023
@julienrbrt julienrbrt removed the status in Cosmos-SDK Jan 17, 2023
@julienrbrt julienrbrt moved this to 👀 Needs Review in Cosmos-SDK Jan 17, 2023
@github-project-automation github-project-automation bot moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Jan 17, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants