Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup ICS 2 implementation #5510

Closed
cwgoes opened this issue Jan 10, 2020 · 3 comments
Closed

Cleanup ICS 2 implementation #5510

cwgoes opened this issue Jan 10, 2020 · 3 comments
Assignees
@fedekunze
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Milestone
IBC 1.0 [Implemen...

Comments

@cwgoes
Copy link
Contributor

cwgoes commented Jan 10, 2020

Is the handler used anymore? Seems not to be. Let's not leave redundant code in.

Also double-check that all events are correct & present.
@cwgoes cwgoes added the x/ibc label Jan 10, 2020
@cwgoes cwgoes mentioned this issue Jan 10, 2020
Merged
11 tasks
@fedekunze
Copy link
Collaborator

fedekunze commented Jan 10, 2020 •
edited
Loading

I'm doing some cleanup on #5485. Once #5401 and #5485 are merged I'll double-check this

@fedekunze fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. S:blocked Status: Blocked labels Jan 10, 2020
@cwgoes cwgoes assigned fedekunze and unassigned mossid Jan 21, 2020
@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 3, 2020

Both have been merged - should we be able to tackle this now? I can help if you like.

@fedekunze
Copy link
Collaborator

We can close this

@fedekunze fedekunze removed the S:blocked Status: Blocked label Feb 3, 2020
@fedekunze fedekunze added this to the IBC Implementation milestone Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fedekunze fedekunze

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
IBC 1.0 [Implementation]
Development

No branches or pull requests
3 participants
@mossid @cwgoes @fedekunze