Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test that baseapp correctly handles gas on aborted txs #3259

Closed
ValarDragon opened this issue Jan 9, 2019 · 4 comments · Fixed by #3468
Closed

Test that baseapp correctly handles gas on aborted txs #3259

ValarDragon opened this issue Jan 9, 2019 · 4 comments · Fixed by #3468
Assignees
@alexanderbez
Labels
C:baseapp T: Tests
Milestone
v0.31.0 (Launch RC)

Comments

@ValarDragon
Copy link
Contributor

Essentially a test case for #3244
@cwgoes
Copy link
Contributor

cwgoes commented Jan 9, 2019

Let's do this; baseapp in general needs far better test coverage.

@cwgoes
Copy link
Contributor

cwgoes commented Jan 21, 2019 •
edited
Loading

cc @sunnya97 - interested / thoughts?

@alexanderbez
Copy link
Contributor

If not, I can pick it up.

@jackzampolin
Copy link
Member

@alexanderbez this would be a great test to add.

@jackzampolin jackzampolin added this to the v0.30.0 (Launch RC) milestone Jan 29, 2019
@ebuchman ebuchman mentioned this issue Jan 29, 2019
Closed
3 tasks
@alexanderbez alexanderbez mentioned this issue Feb 1, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:baseapp T: Tests
Projects
None yet
Milestone
v0.31.0 (Launch RC)
Development

Successfully merging a pull request may close this issue.

R4R: Increase BaseApp Test Coverage cosmos/cosmos-sdk
4 participants
@alexanderbez @ValarDragon @jackzampolin @cwgoes