Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure consistency -> core gaia commands to NOT use tendermint pubkey #1902

Closed
rigelrozanski opened this issue Aug 1, 2018 · 2 comments
Closed

Ensure consistency -> core gaia commands to NOT use tendermint pubkey #1902

rigelrozanski opened this issue Aug 1, 2018 · 2 comments
Labels
C:CLI C:x/staking T: UX

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Aug 1, 2018 •
edited
Loading

Ref: #1884

This has been very confusing and led to a large discussion. For the time being we should be consistent and use ONLY the operator cosmosValAddr (when referring to a validator) and cosmosAccAddr (when sending funds etc.).

related: https://github.com/cosmos/cosmos-sdk/blob/develop/docs/spec/other/bech32.md
@rigelrozanski rigelrozanski mentioned this issue Aug 1, 2018
Closed
@cwgoes
Copy link
Contributor

cwgoes commented Aug 1, 2018

In core commands and also in store keys, as we'll soon no longer have the PubKey through ABCI.

@rigelrozanski rigelrozanski mentioned this issue Aug 2, 2018
Closed
4 tasks
@jackzampolin
Copy link
Member

I think this work has been completed by the CLI refactor. Going to close this issue. Reopen if I'm wrong!

@rigelrozanski rigelrozanski reopened this Sep 7, 2018
@neutron-robot neutron-robot mentioned this issue Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CLI C:x/staking T: UX
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jackzampolin @rigelrozanski @cwgoes