Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the relevant validation for classID and nftID from x/nft #13819

Closed
dreamer-zq opened this issue Nov 10, 2022 · 0 comments · Fixed by #13836
Closed

Remove the relevant validation for classID and nftID from x/nft #13819

dreamer-zq opened this issue Nov 10, 2022 · 0 comments · Fixed by #13836

Comments

@dreamer-zq
Copy link
Collaborator

dreamer-zq commented Nov 10, 2022

Summary

Remove the relevant validation for classID and nftID from x/nft

Problem Definition

The current x/nft module in cosmos-sdk restricts the format of classID and nftID [a-zA-Z][a-zA-Z0-9/:-]{2,100}, which is not friendly to upper-layer applications , for example, the tokenId defined in eip-721 is uint256, etc. When using ics721 for nft cross-chain, the receiving chain (using the x/nft module) may not be able to perform related operations on nft, such as query, transfer, etc., which restricts usage scenarios

Proposal

so It is recommended to delete the relevant verification of classID and nftID from x/nft, and the specific verification logic is controlled by the upper-layer application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant