Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEXTUAL ValueRenderers Add decimals & sdk.Coins parsing #13153

Closed
4 tasks
amaury1093 opened this issue Sep 5, 2022 · 1 comment · Fixed by #13696
Closed
4 tasks

TEXTUAL ValueRenderers Add decimals & sdk.Coins parsing #13153

amaury1093 opened this issue Sep 5, 2022 · 1 comment · Fixed by #13696
Assignees
@amaury1093 @atheeshp

Comments

@amaury1093
Copy link
Contributor

Summary

part of #11970

Formatting for integers, decimals and sdk.Coins have been done in #12613 and #12729. We should add the reverse operation: Parse.

Proposal

  • Add parsing for integers
  • Add parsing for decimals
  • Add parsing for sdk.Coin and sdk.Coins
  • Use existing test case JSONs

This can be done in one single PR
This was referenced Sep 5, 2022
Closed
Merged
@amaury1093 amaury1093 mentioned this issue Sep 15, 2022
Merged
19 tasks
@amaury1093
Copy link
Contributor Author

Note: the parsing functions should go in:

  • parse integers and decimals: math package
  • parse coins: core/coins package

See #13306

@amaury1093 amaury1093 moved this to 📝 Todo in Cosmos-SDK Oct 10, 2022
@amaury1093 amaury1093 self-assigned this Oct 10, 2022
@atheeshp atheeshp mentioned this issue Oct 31, 2022
Merged
19 tasks
@amaury1093 amaury1093 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Nov 2, 2022
@amaury1093 amaury1093 moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Nov 16, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Dec 2, 2022
@tac0turtle tac0turtle removed this from Cosmos-SDK Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaury1093 amaury1093

@atheeshp atheeshp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: implement parse method for Int,Dec,Coin cosmos/cosmos-sdk
2 participants
@amaury1093 @atheeshp