Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average time to evaluate rule groups is higher when using streaming of chunks #3957

Open
pstibrany opened this issue Mar 16, 2021 · 8 comments
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. keepalive Skipped by stale bot

Comments

@pstibrany
Copy link
Contributor

When using streaming of chunks as implemented in #3889, average time to evaluate rule groups goes up.

@pracucci pracucci added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Mar 16, 2021
@pracucci
Copy link
Contributor

Is it because of the chunks decoding done in the ruler (instead of spreading it across all ingesters)? Do you have any ruler trace to investigate it further?

@pstibrany
Copy link
Contributor Author

pstibrany commented Mar 16, 2021

Is it because of the chunks decoding done in the ruler (instead of spreading it across all ingesters)?

I assume that is the case, but haven't investigated it further yet. What is worrying is that rule evaluation has doubled in average, but it could also be specific to rules.

@stale
Copy link

stale bot commented Jun 14, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 14, 2021
@stale stale bot closed this as completed Jun 30, 2021
@pstibrany
Copy link
Contributor Author

Still valid

@pstibrany pstibrany reopened this Jun 30, 2021
@stale stale bot removed the stale label Jun 30, 2021
@bboreham
Copy link
Contributor

Was this fixed by #4341 ?

@bboreham
Copy link
Contributor

bboreham commented Nov 8, 2021

Answering my own question: no it was not fixed. That part improves, but mergeIterator seems to be so much slower that it defeats the improvement.

@stale
Copy link

stale bot commented Feb 8, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 8, 2022
@stale stale bot closed this as completed Mar 3, 2022
@friedrichg friedrichg reopened this Mar 12, 2023
@stale stale bot removed the stale label Mar 12, 2023
@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 18, 2023
@friedrichg friedrichg added the keepalive Skipped by stale bot label Jun 19, 2023
@stale stale bot removed the stale label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. keepalive Skipped by stale bot
Projects
None yet
Development

No branches or pull requests

4 participants