Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit series per query in the blocks storage #3669

Closed
pracucci opened this issue Jan 8, 2021 · 1 comment · Fixed by #4179 or #4216
Closed

Limit series per query in the blocks storage #3669

pracucci opened this issue Jan 8, 2021 · 1 comment · Fixed by #4179 or #4216
Labels
storage/blocks Blocks storage engine type/feature

Comments

@pracucci
Copy link
Contributor

pracucci commented Jan 8, 2021

Is your feature request related to a problem? Please describe.
The chunks storage support the -ingester.max-series-per-query limit, which allows to configure the maximum number of series for which a query can fetch samples from ingesters. It's not a full support to limit series per query, because the limit is enforced in the ingesters only.

Blocks storage doesn't support it at all.

Describe the solution you'd like
Ideally, we should limit series per query in the blocks storage, both when fetching samples from ingesters and long term storage. The store-gateway internally supports a series limit (we're currently not using it), but that would be enforced in a single store-gateway only. We could do it, plus enforced in ingesters and queriers, to have a real limit implementation.

@stale
Copy link

stale bot commented Apr 10, 2021

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage/blocks Blocks storage engine type/feature
Projects
None yet
1 participant