Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable querier.ingester-streaming by default #1753

Closed
paulcostinean opened this issue Oct 23, 2019 · 3 comments
Closed

Enable querier.ingester-streaming by default #1753

paulcostinean opened this issue Oct 23, 2019 · 3 comments
Labels
keepalive Skipped by stale bot

Comments

@paulcostinean
Copy link

From my (limited) experience with cortex, it looks like queries with large enough results will fail to return with an error from the grpc client, unless streaming rpc is enabled.

 grpc: trying to send message larger than max

The maximum grpc message size is ~4MB.

@paulcostinean paulcostinean changed the title Enable ingester-streaming by default Enable querier.ingester-streaming by default Oct 23, 2019
@bboreham
Copy link
Contributor

Do note #1195 should be investigated / fixed before we do this.

@stale
Copy link

stale bot commented Feb 3, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 3, 2020
@pracucci pracucci added keepalive Skipped by stale bot and removed stale labels Feb 3, 2020
@bboreham
Copy link
Contributor

Closed by #2344 (though #1195 is still a big efficiency hit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive Skipped by stale bot
Projects
None yet
Development

No branches or pull requests

3 participants