This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1: Add hostname to /etc/hosts #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
suggested changes
Jan 10, 2017
| } | ||
| hostnamePath := filepath.Join(common.Stage1RootfsPath(p.Root), "etc/hostname") | ||
| if err := ioutil.WriteFile(hostnamePath, []byte(p.Hostname), 0644); err != nil { | ||
| log.FatalE("error writing "+hostnamePath, err) |
There was a problem hiding this comment.
Here and below, please don't FatalE. Log the error and return 254 instead, so defers can run.
There was a problem hiding this comment.
Good catch, though I was just matching style. This whole file needs to be fixed; I can take care of that in another PR.
There was a problem hiding this comment.
Yes, I'm also guilty of introducing some of those FatalE, but I think we can gradually phase them out.
lucab
added
component/stage1
kind/bug
kind/regression
needs/some-changes
and removed
needs/review
kind/bug
labels
squeed
force-pushed
the
machine-hostname
branch
from
468e167 to
3a26e43
Compare
|
@lucab thanks, updated! Also, added a test file I forgot to commit earlier. |
This fixes a regression where the pod's hostname was missing from /etc/hosts Fixes rkt#3422
squeed
force-pushed
the
machine-hostname
branch
from
3a26e43 to
e0b450e
Compare
lucab
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where the pod's hostname was missing from /etc/hosts
Fixes #3422