This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
30ignition/ignition-setup-user: mount /boot partition ro #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't actually need write access to `/boot` here to pull out any baked Ignition config. Just mount it read-only. This also helps in the case where any other service is concurrently also mounting `/boot`: trying to mount a device as read-write that's already mounted read-only elsewhere will fail. I hit this when playing with FIPS mode, which does this: https://github.com/dracutdevs/dracut/blob/718aefda1374c7b6c3790b08cae27fd6bde505af/modules.d/01fips/fips.sh#L49
|
Not sure if there's a cleaner way to solve this. Note that mount namespaces/propagation doesn't solve this; understandably, those restrictions apply system-wide. |
|
We'll need this backported to the spec2x branch as well. |
jlebon
added a commit
to jlebon/ignition-dracut
that referenced
this pull request
Nov 7, 2019
We don't actually need write access to `/boot` here to pull out any baked Ignition config. Just mount it read-only. This also helps in the case where any other service is concurrently also mounting `/boot`: trying to mount a device as read-write that's already mounted read-only elsewhere will fail. I hit this when playing with FIPS mode, which does this: https://github.com/dracutdevs/dracut/blob/718aefda1374c7b6c3790b08cae27fd6bde505af/modules.d/01fips/fips.sh#L49 (backport of coreos#134)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't actually need write access to
/boothere to pull out anybaked Ignition config. Just mount it read-only.
This also helps in the case where any other service is concurrently also
mounting
/boot: trying to mount a device as read-write that's alreadymounted read-only elsewhere will fail. I hit this when playing with FIPS
mode, which does this:
https://github.com/dracutdevs/dracut/blob/718aefda1374c7b6c3790b08cae27fd6bde505af/modules.d/01fips/fips.sh#L49