This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
chore(requests): more error info for SendRequest #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
etcd-io/etcd#576 |
|
It should print out error in connection. Or we just know that it tries many times and fails at last. |
|
@unihorn The error message will not be consumed by a program anyway. I think we might just add log warn to log the actual error? |
|
@xiangli-cmu It could be returned back, and I read it under the etcd -vv mode. |
|
@unihorn I mean you can not consume it programmatically. If we want to print it out, why not all the errors but only the last one? |
|
@xiangli-cmu Yes. It could be kind of weird. Maybe I should make go-etcd all debug infomation print out instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.