-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: revert "internal" package changes #9274
Conversation
Marked it as WIP. We need to research more if there's any better way to handle it, before 3.4 release. |
I will revert |
373b8bd
to
014714f
Compare
d9f5e1d
to
967964b
Compare
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9274 +/- ##
==========================================
+ Coverage 72.74% 72.76% +0.01%
==========================================
Files 361 361
Lines 30717 30717
==========================================
+ Hits 22346 22352 +6
+ Misses 6766 6758 -8
- Partials 1605 1607 +2
Continue to review full report at Codecov.
|
External tools like "etcd-dump-db" outside of etcd repository need
access to "mvccpb" and other packages. Should not be under
internal
.Also projects that use clientv3 use
mvccpb.PUT
, and so on.See https://github.com/search?l=Go&q=mvccpb.&type=Code&utf8=%E2%9C%93.