e2e grpcproxy tests #8277
Merged
e2e grpcproxy tests #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyuho no need to backport the transport one-- there's special cases everywhere to set it in the tls.Config derived from the tlsinfo. The snapshot EOF patch seems worth backporting though. |
heyitsanthony
force-pushed
the
test-e2e-grpcproxy
branch
from
f3bbd81 to
338160d
Compare
|
What is |
heyitsanthony
force-pushed
the
test-e2e-grpcproxy
branch
from
338160d to
cd00945
Compare
|
@gyuho EndpointsJSON wasn't needed; removed |
heyitsanthony
force-pushed
the
test-e2e-grpcproxy
branch
from
cd00945 to
8f4f722
Compare
heyitsanthony
force-pushed
the
test-e2e-grpcproxy
branch
from
8f4f722 to
ae601f6
Compare
gyuho
reviewed
Jul 20, 2017
| for i := 0; i < len(cfg.tlsArgs); i++ { | ||
| switch cfg.tlsArgs[i] { | ||
| case "--cert-file": | ||
| tlsArgs = append(tlsArgs, "--cert", cfg.tlsArgs[i+1], "--cert-file", cfg.tlsArgs[i+1]) |
There was a problem hiding this comment.
Why do we have duplicate flags "--cert-file", cfg.tlsArgs[i+1] (for etcd) in etcd grpc-proxy command?
There was a problem hiding this comment.
--cert is proxy <-> etcd (in grpcproxy already), --cert-file is client <-> proxy (new)
heyitsanthony
force-pushed
the
test-e2e-grpcproxy
branch
from
cf8c515 to
95a1bff
Compare
gyuho
reviewed
Jul 20, 2017
| switch os.Args[1] { | ||
| cmd := os.Args[1] | ||
| if covArgs := os.Getenv("ETCDCOV_ARGS"); len(covArgs) > 0 { | ||
| args := strings.Split(os.Getenv("ETCDCOV_ARGS"), "\xe7\xcd")[1:] |
There was a problem hiding this comment.
string separator, in case there's a space in the arguments; etcdctl has something similar since the arguments can't be passed via command line when enabling coverage instrumentation
heyitsanthony
force-pushed
the
test-e2e-grpcproxy
branch
from
b7805f7 to
954ec4d
Compare
added 11 commits
July 21, 2017 11:00
Some functions take a TLSInfo to generate a tls.Config and there was no way to force the InsecureSkipVerify flag.
Was defaulting to PeerTLSInfo for client connections to the etcd cluster. Since proxy users may rely on this behavior, only use the client tls info if given, and fall back to peer tls otherwise.
Enables TLS termination in grpcproxy.
Gets "code = OutOfRange desc = EOF" errors otherwise.
Was dropping the last argument in the slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables -tags cluster_proxy for e2e.
Turns out a lot of stuff was broken! Skips v3 auth tests for now.