lease: guard 'Lease.itemSet' from concurrent writes #7457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsanthony
suggested changes
Mar 8, 2017
lease/lessor.go
Outdated
| @@ -515,6 +520,9 @@ func (l *Lease) expired() bool { | |||
| } | |||
|
|
|||
| func (l *Lease) persistTo(b backend.Backend) { | |||
| l.mu.RLock() | |||
There was a problem hiding this comment.
doesn't need to be acquired since not touching itemSet?
lease/lessor.go
Outdated
| @@ -530,12 +538,15 @@ func (l *Lease) persistTo(b backend.Backend) { | |||
|
|
|||
| // TTL returns the TTL of the Lease. | |||
| func (l *Lease) TTL() int64 { | |||
| return l.ttl | |||
| l.mu.RLock() | |||
There was a problem hiding this comment.
doesn't need to be acquired since not touching itemSet?
lease/lessor.go
Outdated
| @@ -501,6 +505,7 @@ func (le *lessor) initAndRecover() { | |||
| } | |||
|
|
|||
| type Lease struct { | |||
| mu sync.RWMutex | |||
There was a problem hiding this comment.
// mu protects concurrent accesses to itemSet?
lease/lessor_test.go
Outdated
| } | ||
|
|
||
| <-donec | ||
| } |
lease/lessor.go
Outdated
| } | ||
|
|
||
| // refresh refreshes the expiry of the lease. | ||
| func (l *Lease) refresh(extend time.Duration) { | ||
| t := monotime.Now().Add(extend + time.Duration(l.ttl)*time.Second) | ||
| t := monotime.Now().Add(extend + time.Duration(l.TTL())*time.Second) |
|
@heyitsanthony Yeah fixed it to only protect |
heyitsanthony
approved these changes
Mar 8, 2017
|
lgtm. Thanks! |
|
change this to |
Fix etcd-io#7448. Affected if etcd builds with Go 1.8+. Signed-off-by: Gyu-Ho Lee <[email protected]>
fanminshi
approved these changes
Mar 8, 2017
|
lgtm thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7448.
Affected if etcd builds with Go 1.8+.