Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tags #184

Closed
cgwalters opened this issue Oct 24, 2018 · 4 comments
Closed

Add support for tags #184

cgwalters opened this issue Oct 24, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@cgwalters
Copy link
Member

Currently the model is that builds.json implements a linear stream of builds, a lot like ostree/git commits. But we should add the concept of tagging.

See prior discussion in e.g. #177

What I'm thinking here is that builds.json would look like:

{ "builds": ["42.4", "42.3", "42.2"]
  "tags": [{"name": "smoketested",
               "created": "2018-09-26T15:51:42Z",
               "target": "42.3"}, ...]
}

Created by e.g.: coreos-assembler build-tag create smoketested 42.3

Our pruning logic would be enhanced to understand these additional references.

@cgwalters cgwalters added the enhancement New feature or request label Oct 24, 2018
@wking
Copy link

wking commented Oct 24, 2018

Cross-linking openshift/os#351.

@jlebon
Copy link
Member

jlebon commented Dec 4, 2018

PR for the tag command in #243.

@jlebon
Copy link
Member

jlebon commented Dec 5, 2018

PR for teaching prune about tags in #245.

@cgwalters
Copy link
Member Author

I think we can call this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants