Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show installation progress when solana_version is not installed in CLI #2724

Closed
acheroncrypto opened this issue Dec 10, 2023 · 4 comments
Closed
Assignees
Labels
cli good first issue Good for newcomers

Comments

@acheroncrypto
Copy link
Collaborator

Problem

During solana_version toolchain override, we set the standard I/O stream to Stdio::null in order to avoid displaying the switching process via solana-install init command. The process can take a while if the given Solana version is not installed but there is no indication of a new installation.

Solution

Anchor should only set the standard I/O stream to Stdio:null if the given solana_version is already installed. That way, users will be able to see the installation process when necessary.

@acheroncrypto acheroncrypto added good first issue Good for newcomers cli labels Dec 10, 2023
@simplysabir
Copy link
Contributor

Hey @acheroncrypto , can i work on this issue? i kind of understood the problem and have implementation in mind and have written that too.

@acheroncrypto
Copy link
Collaborator Author

Yeah, sure!

@simplysabir
Copy link
Contributor

@acheroncrypto hey raised the PR, kindly have a look!!

#2757

@acheroncrypto
Copy link
Collaborator Author

Resolved in #2757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants