Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wish] Rename default branch to main instead of master #102

Open
ejgallego opened this issue Feb 7, 2025 · 4 comments
Open

[wish] Rename default branch to main instead of master #102

ejgallego opened this issue Feb 7, 2025 · 4 comments

Comments

@ejgallego
Copy link
Member

Dear stdlib devs,

it's been a while that the convention in large parts of the git world for the name of the default repository branch is main instead of master. Github adopted this policy in 2020 for example.

I'm opening this issue to ask you to consider the renaming, in the past we avoided this due to breakage in the Coq world, but given that this is a new repos the breakage would be quite minor if I am correct.

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 10, 2025

Note that the stdlib repo is a fork of the Coq repo (in git history sense), which explains why this name was used.

I'm opening this issue to ask you to consider the renaming, in the past we avoided this due to breakage in the Coq world, but given that this is a new repos the breakage would be quite minor if I am correct.

@proux01 @CohenCyril would it work for the Coq Nix Toolbox dev testing to have stdlib use main as its branch name and Coq / Rocq use master?

Besides that, I think the main breakage that would have to be fixed would be the branch being tracked in the Coq's CI (and perhaps also in the opam dev package).

Note that GitHub has support for renaming branches so perhaps, we would not get any breakage at all (if it correctly redirects). And then, the question should be asked whether to rename the main branch on the Coq / Rocq repo as well.

@proux01
Copy link
Contributor

proux01 commented Feb 10, 2025

FWIW, according to CI config, the vast majority of devs still use master. We could switch, I don't really, care. Adaptation would probably be fairly easy, but not sure it's worth the effort. For sure, I wouldn't make it myself, but I wouldn't oppose either if anyone is really willing to do all the required PRs for CIs everywhere (provided the github renaming feature is not up to the task).

@proux01 @CohenCyril would it work for the Coq Nix Toolbox dev testing to have stdlib use main as its branch name and Coq / Rocq use master?

I don't see any fundamental issue (other than it being a bit confusing)

@Zimmi48
Copy link
Member

Zimmi48 commented Feb 10, 2025

would it work for the Coq Nix Toolbox dev testing to have stdlib use main as its branch name and Coq / Rocq use master?

I don't see any fundamental issue (other than it being a bit confusing)

It's just that I checked and I didn't find the code that Nix uses to decide that when building Coq master it needs the Stdlib master or main branch. Does it just reuse the exact same version?

@proux01
Copy link
Contributor

proux01 commented Feb 10, 2025

There is no such code, when you override coq you're are free to override the stdlib or not, so there is no link between the name of the two branches. Stdlib is a library, like any other for that respect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants