You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code is mostly a duplicate of the code in the BrokerController (in fact it was originally copied from there). Should we abstract this out as a helper method in the broker itself?
/** * Get or start worker. */publicsynchronizedStringgetOrStartWorker(WorkerCategoryworkerCategory, WorkerTagsworkerTags) {
Stringaddress = getWorkerAddress(workerCategory);
if (address == null) {
// There are no workers that can handle this request. Request some.createOnDemandWorkerInCategory(workerCategory, workerTags);
} else {
// Workers exist in this category, clear out any record that we're waiting for one to start up.// FIXME the tracking of which workers are starting up should really be encapsulated using a "start up if needed" method.recentlyRequestedWorkers.remove(workerCategory);
}
returnaddress;
}
At the very least, we shouldn't leave the replicated FIXME in two different places.
This code is mostly a duplicate of the code in the
BrokerController
(in fact it was originally copied from there). Should we abstract this out as a helper method in the broker itself?At the very least, we shouldn't leave the replicated
FIXME
in two different places.Originally posted by @trevorgerhardt in #782 (comment)
The text was updated successfully, but these errors were encountered: