fix: improve error messaging #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2wce
reviewed
Sep 18, 2024
| @@ -180,7 +188,13 @@ export function getAllTaggedElements({ | |||
| for (const { node, text } of stegaNodes) { | |||
| const sourceMap = decode(text); | |||
| if (!sourceMap || !sourceMap.origin.includes('contentful.com')) { | |||
| debug.warn; | |||
| debug.warn( | |||
| "Element has missing or invalid ContentSourceMap, please check if you have correctly enabled ContentSourceMaps and that the element's data originates from Contentful", | |||
There was a problem hiding this comment.
@MayaGillilan are we trying to imply that the data shouldn't be transformed once it comes from our APIs?
There was a problem hiding this comment.
I have to admit I'm not as familiar with CSM so that was my understanding, but if that's an inaccurate description please let me know what would be more accurate
There was a problem hiding this comment.
@2wce @YvesRijckaert Can you confirm if this is an appropriate message?
MayaGillilan
changed the title
aodhagan-cf
reviewed
Sep 24, 2024
| @@ -34,6 +34,17 @@ export class LiveUpdates { | |||
|
|
|||
| const subscription = this.subscriptions.get(subscriptionId); | |||
|
|
|||
| if (!data.sys || !data.sys.id) { | |||
There was a problem hiding this comment.
@MayaGillilan Just as an FYI: this broke live updates for GraphQL:
data could look like this for GraphQL:
{
"postCollection": {
"items": [
{
"__typename": "Post",
"sys": {
"id": "a1b2c3"
},
"slug": "foo",
"title": "new value",
]
}
]
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes debug messaging more explicit and meaningful, so as to make configuration issues and user debugging easier