Implement Kubernetes Selectors, minor kube endpoint fix #516
Conversation
pnegahdar
changed the title
|
Wow awesome thanks.. Might we be able to validate the label selector? Oh and the build is failing because you need to run gofmt... |
|
Yeah as I mentioned in the issue the selectors have a special syntax that would be difficult to parse without importing the kube code. |
|
I tend to agree with @pnegahdar to NOT import k8s code 😄 |
| if err != nil { | ||
| return watchCh, errCh, fmt.Errorf("Unable to construct query args") | ||
| } | ||
| request := c.request(url, string(queryData)) |
There was a problem hiding this comment.
This looks very similar to L57-65 could we extract a function to dry it up a little.
|
@pnegahdar could you squash your commit too 👼 |
|
Sure. 2 (one per issue) or just 1? |
|
One per issue is perfect :) |
|
LGTM |
| @@ -272,7 +272,8 @@ func NewTraefikDefaultPointersConfiguration() *TraefikConfiguration { | |||
| //default Kubernetes | |||
| var defaultKubernetes provider.Kubernetes | |||
| defaultKubernetes.Watch = true | |||
| defaultKubernetes.Endpoint = "http://127.0.0.1:8080" | |||
| defaultKubernetes.Endpoint = "" | |||
There was a problem hiding this comment.
Why did you remove this default value ?
There was a problem hiding this comment.
To know if it was explicitly provided to decide whether to use the
kubernetes provide environment variables. It falls back to the 127 default
otherwise
On Wednesday, July 13, 2016, Emile Vauge [email protected] wrote:
In configuration.go
#516 (comment):@@ -272,7 +272,8 @@ func NewTraefikDefaultPointersConfiguration() *TraefikConfiguration {
//default Kubernetes
var defaultKubernetes provider.Kubernetes
defaultKubernetes.Watch = true
- defaultKubernetes.Endpoint = "http://127.0.0.1:8080"
- defaultKubernetes.Endpoint = ""
Why did you remove this default value ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/containous/traefik/pull/516/files/9f6484a328127189009d83dd2758115ccc4529c1#r70667451,
or mute the thread
https://github.com/notifications/unsubscribe/AAy2K8s6E9x8sQMKsWvvaLn_IL666OMEks5qVRyKgaJpZM4JKDPu
.
|
LGTM |
No description provided.