Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested wildcard ACME challenge with DNSimple #4384

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

tstackhouse
Copy link
Contributor

@tstackhouse tstackhouse commented Jan 11, 2019

What does this PR do?

Update docs to reflect DNSimple wildcard ACME challenge

Motivation

I use DNSimple for my DNS and am using Traefik for my service routing and I wanted HTTPS support.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I think I tested root as well, I have a config not unlike

[[acme.domains]]
  main = "*.MYDOMAIN.com"
  sans = ["MYDOMAIN.com"]

And it seems to work properly.

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

I think I tested root as well, I have a config not unlike 

```[[acme.domains]]
  main = "*.MYDOMAIN.com"
  sans = ["MYDOMAIN.com"]```

And it seems to work properly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants