Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed repeated entryPoints.http from grpc.md #4370

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

ishaanbahal
Copy link

The TOML config was invalid with a second [entryPoints.http]. Removed.

What does this PR do?

GRPC docs for Traefik contain an invalid config, with a repeated [entryPoints.http].

Motivation

Observed the issue, checked if already existing issue, couldn't find one, so created PR since its an easy fix to docs.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

This is only a documentation change, from my limited knowledge of TOML. Feel free to ignore if its already correct.

@ishaanbahal ishaanbahal requested review from a team as code owners January 8, 2019 20:31
@ldez ldez changed the base branch from master to v1.7 January 8, 2019 20:31
@ldez ldez removed request for a team January 8, 2019 20:31
@ldez ldez added this to the 1.7 milestone Jan 11, 2019
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The TOML config was invalid with a second `[entryPoints.http]`. Removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants