Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ACME spec and Cloudflare. #4201

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Fix ACME spec and Cloudflare. #4201

merged 1 commit into from
Nov 16, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Nov 15, 2018 •
edited
Loading

What does this PR do?

Fixes:

  • Cloudflare error
  • ACME: Support POST-as-GET
  • ACME: TLS-ALPN-01: Update idPeAcmeIdentifierV1

Extra:

  • Add DNS Provider for conoha, httpreq, inwx, mydnsjp, selectel, transip, vscale

Motivation

Fixes #4200

More

  • [-] Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 1.7 milestone Nov 15, 2018
@ldez ldez added the bot/light-review decreases the number of required LGTM from 3 to 1. label Nov 16, 2018
jbdoumenjou
jbdoumenjou approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 53201b6 into traefik:v1.7 Nov 16, 2018
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Nov 16, 2018
@traefiker traefiker mentioned this pull request Nov 16, 2018
Closed
@ldez ldez mentioned this pull request Nov 19, 2018
Merged
17 tasks
@ldez ldez deleted the fix/cloudflare branch November 19, 2018 23:32
@mmatur mmatur changed the title fix: ACME spec and Cloudflare. Fix ACME spec and Cloudflare. Nov 29, 2018
@mmatur mmatur mentioned this pull request Nov 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @jbdoumenjou @traefiker