Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kubernetes TLS user guide #4175

Merged
merged 2 commits into from
Nov 14, 2018
Merged

Improve kubernetes TLS user guide #4175

merged 2 commits into from
Nov 14, 2018

Conversation

mterring
Copy link

@mterring mterring commented Nov 8, 2018 •
edited by ldez
Loading

What does this PR do?

Add details on how to configure TLS port on kubernetes

Motivation

Getting the syntax of this command right was difficult (most examples have quotes for shells, which cause errors on kubernetes).

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@mterring mterring requested a review from a team as a code owner November 8, 2018 06:28
@ldez ldez added this to the 1.7 milestone Nov 8, 2018
@mmatur mmatur changed the base branch from master to v1.7 November 8, 2018 10:09
SantoDE
SantoDE approved these changes Nov 8, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

dtomcej
dtomcej suggested changes Nov 8, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we don't want to enable compression without the user wanting it in a user guide 😄

dtomcej
dtomcej approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

ldez
ldez reviewed Nov 14, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d0aa993 into traefik:v1.7 Nov 14, 2018
@ldez ldez mentioned this pull request Nov 19, 2018
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@mterring @SantoDE @ldez @dtomcej @traefiker