Fix Rancher Healthcheck when upgrading a service

[jmirc]

What does this PR do?

Here is the small change I did to fix the issue. I tested locally and it works.

Motivation

Fixes #2279

More

• Added/updated tests

Additional Notes

It is my first go changes so I am sure this could be better.

[nmengin]

WDYT @containous/rancher ?

[SantoDE]

Hi @jmirc ,

Thanks for your contribution. One question though: what is the idea to not filter upgrading containers? To not filter "upgraded" is fine imho. But I'm wondering about "upgrading"?

[jmirc]

Hi @SantoDE ,

I am not filtering a service with the upgrading state because it doesn't mean the service can't receive load. An upgrading state is just meaning that the service is upgrading. The solution to avoid any downtimes of your service is to check the "Start before stopping" checkbox. With this option, a new container is started and once it is running the previous version is stopped. It doesn't mean the service can't receive any calls.

Actually, the service is filtering when the state is upgrading, that's mean a call to this service will return a 404 which is not what we want.

Let me know if it is not clear enough.

[SantoDE]

Hi @jmirc,

okay, then it's what I expected :)

For Services, I'm fine to pass them traffic as long as there healthstate is upgrading. However, I'm unsure about not filtering containers which state is upgrading. Imho, it would be better to not pass them traffic until they are healthy.

WDYT?

[jmirc]

Hi SantoDE,

I agree with you. We should not pass traffic to the container with an upgrading state

Jerome

[ldez]

LGTM

[mmatur]

LGTM

[nmengin]

LGTM 🐮