Fix goroutine leak in throttler logic. #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
added
status/2-needs-review
kind/bug/confirmed
timoreimann
force-pushed
the
fix-throttle-goroutine-leak
branch
2 times, most recently
from
4e58a0a to
f185f2c
Compare
ldez
added
kind/bug/fix
mmatur
approved these changes
Jan 23, 2018
The variable managing throttling goroutines was only scoped to the local method, effectively disabling goroutine cleanup and producing a leak. We properly hook up the goroutines to live as long as the server does.
traefiker
force-pushed
the
fix-throttle-goroutine-leak
branch
from
f185f2c to
17b31d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a goroutine leak in the throttling logic.
Additional Notes
The variable managing throttling goroutines was only scoped to the local method, effectively disabling goroutine cleanup and producing a leak. We properly hook up the goroutines to live as long as the server does.
This PR partially supersedes #2728.