Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad Træfik update on Consul Catalog #2573

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Fix bad Træfik update on Consul Catalog #2573

merged 1 commit into from
Dec 15, 2017

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Dec 15, 2017

What does this PR do?

This PR fix a bad Træfik update when there is a Consul Catalog service change

Fixes #2552

@traefiker traefiker added this to the 1.5 milestone Dec 15, 2017
nmengin
nmengin approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Dec 15, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Dec 15, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix-missing-server-consul branch from 1158a53 to 36db3af Compare December 15, 2017 14:38
@traefiker traefiker merged commit 48b4eb5 into traefik:v1.5 Dec 15, 2017
@traefiker traefiker mentioned this pull request Dec 15, 2017
Closed
@mmatur mmatur deleted the fix-missing-server-consul branch March 21, 2018 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/consulcatalog kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@mmatur @juliens @ldez @nmengin @traefiker