Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix for docker volume vs created directory #2372

Merged
merged 1 commit into from
Nov 8, 2017
Merged

Minor fix for docker volume vs created directory #2372

merged 1 commit into from
Nov 8, 2017

Conversation

visibilityspots
Copy link
Contributor

@visibilityspots visibilityspots commented Nov 7, 2017 •
edited by ldez
Loading

What does this PR do?

Fixed documentation by aligning docker-compose volumes vs instructed creation of directory

Motivation

sharing is caring

More

  • Added/updated documentation

mmatur
mmatur approved these changes Nov 8, 2017
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez changed the base branch from master to v1.4 November 8, 2017 14:01
ldez
ldez approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to the 1.4 milestone Nov 8, 2017
@traefiker traefiker merged commit 58a4381 into traefik:v1.4 Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

@nmengin nmengin nmengin approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@visibilityspots @mmatur @ldez @nmengin @traefiker