Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance documentation. #2048

Merged
merged 3 commits into from
Sep 5, 2017
Merged

Enhance documentation. #2048

merged 3 commits into from
Sep 5, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Sep 3, 2017

Description

@ldez ldez added this to the 1.4 milestone Sep 3, 2017
@ldez ldez requested review from a team as code owners September 4, 2017 10:01
@ldez ldez force-pushed the refactor/doc-enhance branch from ce7cfe9 to c3a821e Compare September 4, 2017 10:16
@ldez ldez requested a review from a team as a code owner September 4, 2017 10:16
@ldez ldez force-pushed the refactor/doc-enhance branch from c3a821e to 24271d2 Compare September 4, 2017 10:20
juliens
juliens approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite my "little comment"
LGTM

mkdocs.yml
# - type: 'slack'
# link: 'https://traefik.herokuapp.com'
# - type: 'twitter'
# link: 'https://twitter.com/traefikproxy'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is commented, we may not have to add it ?

nmengin
nmengin approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📚

@traefiker traefiker force-pushed the refactor/doc-enhance branch from 4983423 to a025789 Compare September 5, 2017 13:28
@traefiker traefiker merged commit b0a0e16 into traefik:v1.4 Sep 5, 2017
@traefiker traefiker mentioned this pull request Sep 5, 2017
Closed
@ldez ldez deleted the refactor/doc-enhance branch September 5, 2017 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@timoreimann timoreimann timoreimann approved these changes

@nmengin nmengin nmengin approved these changes

@traefiker traefiker traefiker approved these changes

Assignees
No one assigned
Labels
area/documentation kind/enhancement a new or improved feature.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @timoreimann @nmengin @traefiker