New oxy with gorilla for websocket with integration tests

[juliens]

• Use the new websocket implementation in oxy, based on gorilla/websocket
• Add integration tests for verify websocket

fixes #1858

In order to reproduce the issue:

docker run -d --name="home-assistant" \
    --restart=always \
    -v $PWD/config:/config \
    -v /etc/localtime:/etc/localtime:ro \
    -p 8123:8123 \
    --label traefik.port=8123 \
    --label traefik.frontend.rule="Host:127.0.0.1" \
    homeassistant/home-assistant

./traefik --docker=true

Then just try to view the homepage (http://127.0.0.1)

[ldez]

LGTM 👏 👏 👏

[emilevauge]

Thanks ☺️
LGTM

[dtomcej]

LGTM

[wader]

Hi, after upgrading to latest traefik (1.3.5) i noticed that query parameter sent in websock requests ends up URL-encoded on the backend server. Had a quick look and this line looks suspicious.

Websocket request:

curl -H "Connection: Upgrade" -H "Upgrade: websocket" -H "Sec-WebSocket-Version: 13" -H "Sec-WebSocket-Key: dummy" http://host/events?token=123

I see a requests to the backend that looks like this: (dumping with tcpdump -A)

GET /events%3Ftoken=123 HTTP/1.1     <-- notice the encoded "?"
Host: host
User-Agent: curl/7.54.0
Accept: */*
Connection: Upgrade
Sec-WebSocket-Key: 92tmVWFXOLFebYZc98UaAw==
Sec-WebSocket-Version: 13
Upgrade: websocket
X-Traefik-Reqid: 82

A normal GET request:

curl http://host/events?token=123

I see a request to the backend that looks like this:

GET /events?token=123 HTTP/1.1
Host: host
User-Agent: curl/7.54.0
Accept: */*
X-Forwarded-For: 1.2.3.4
X-Forwarded-Host: host
X-Forwarded-Proto: https
X-Forwarded-Server: 6ea428775acc
X-Traefik-Reqid: 87
Accept-Encoding: gzip

Now I also noticed that a lot of X-Forwarded headers are missing for the websocket request.

[ldez]

this line fixed the encoding pb. wrong PR 😄

[juliens]

Thx for your report, the problem is already fix, just need to be merge and release
containous/oxy#22

For the x-forwarded, feel free to propose a PR (on github.com/containous/oxy).
Thanks

[wader]

@juliens Ok! thanks for fix and info!