Improve Let's Encrypt documentation #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/acme
area/documentation
kind/enhancement
ldez
force-pushed
the
feature/lets-encrypt-documentation
branch
from
495713e to
9640edb
Compare
nmengin
force-pushed
the
feature/lets-encrypt-documentation
branch
from
9640edb to
99036fe
Compare
|
This PR finally will complete another one #1923 . |
dtomcej
suggested changes
Aug 25, 2017
docs/user-guide/examples.md
Outdated
| [[entryPoints.https.tls.certificates]] | ||
| certFile = "tests/traefik.crt" | ||
| keyFile = "tests/traefik.key" | ||
| CertFile = "/etc/pki/tls/certs/mycert.crt" |
There was a problem hiding this comment.
Can we use a cert and key that exist in the repo already (perhaps from the integration tests), so that we don't provide fictitious paths to confuse new users?
I would either keep the same cert path ("tests/traefik.crt") or choose another from the repo
There was a problem hiding this comment.
we do have some certs in /examples ;)
There was a problem hiding this comment.
@dtomcej I copied the certificate and key files paths from the example HTTP redirect on HTTPS, I change the both.
nmengin
force-pushed
the
feature/lets-encrypt-documentation
branch
from
99036fe to
b3dc0ad
Compare
nmengin
force-pushed
the
feature/lets-encrypt-documentation
branch
from
b3dc0ad to
c449345
Compare
dtomcej
approved these changes
Aug 25, 2017
traefiker
force-pushed
the
feature/lets-encrypt-documentation
branch
from
c449345 to
dc3d961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Feature to improve the let's encrypt documentation.
A user guide has been added to show how to create a Traefik Docker service with Let's Encrypt configuration